Simplify Finding GSL in CMake

Review Request #123968 - Created May 31, 2015 and discarded

Information
David Narváez
labplot
master
Reviewers
kdeedu
kaning

Use the PkgConfig module. Setting compile definitions HAVE_GSL and GSL_VERSION has no effect in the code so I removed them.

Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this still works in the OSX configuration, Marko?

Issues

  • 3
  • 0
  • 0
  • 3
Description From Last Updated
Is this also going to set GSL_CBLAS_LIBRARIES? Raphael Kubo da Costa Raphael Kubo da Costa
This will fail if you're using an older CMake, as you haven't added cmake/ to $CMAKE_MODULE_PATH yet. And to prevent ... Raphael Kubo da Costa Raphael Kubo da Costa
Note that the variable is now called GSL_CBLAS_LIBRARY and not GSL_CBLAS_LIBRARIES, so you need to adjust src/CMakeLists.txt (or use the ... Raphael Kubo da Costa Raphael Kubo da Costa
Stefan Gerlach
Raphael Kubo da Costa
David Narváez
Marko Käning
David Narváez
Raphael Kubo da Costa
David Narváez
David Narváez
Marko Käning
Albert Astals Cid
Marko Käning
Stefan Gerlach
David Narváez
Review request changed

Status: Discarded

Loading...