Implement a cancelled() signal in ReadOnlyArchiveInterface to fix cancellation of password dialogs

Review Request #123967 - Created May 31, 2015 and submitted

Information
Ragnar Thomsen
ark
frameworks
267670
Reviewers
kdeutils
elvisangelaccio, rkcosta

Implement a cancelled() signal in ReadOnlyArchiveInterface. This signal is emitted in CliInterface when the user cancels a password dialog. The signal is connected to a slot in Job which sets KJob::error to KJob::KilledJobError.

The callers (Part and BatchExtract) are modified to do nothing if the error code is KJob::KilledJobError when running ListJobs/ExtractJobs/AddJobs/DeleteJobs. This fixes an issue where the user cancels the "Enter password" dialog and the UI keeps being blocked and/or error messageboxes appear.

The commit ee006cb6a83e6cbd01a2dc459b8b0c8be664c05e in the frameworks branch should be reverted before applying this diff, since this is meant to be an improved replacement of that commit.

Opened a password-protected zip archive, clicked on a file and cancelled the dialog. Opened a password-protected zip archive, selected a file for extraction and cancelled the password dialog. Opened a password-protected rar archive, and cancelled the password dialog. In all cases, the UI is not blocked after cancelling the dialog and no message boxes appear.

Issues

  • 0
  • 2
  • 1
  • 3
Description From Last Updated
Raphael Kubo da Costa
Ragnar Thomsen
Raphael Kubo da Costa
Ragnar Thomsen
Raphael Kubo da Costa
Ragnar Thomsen
Ragnar Thomsen
Raphael Kubo da Costa
Ragnar Thomsen
Raphael Kubo da Costa
Raphael Kubo da Costa
Ragnar Thomsen
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit f4acf9aeca8ce10ac9d5cc900e575ebd3af6c980 by Kevin Funk on behalf of Vladimir Novikov to branch master.
Loading...