KAssistantDialog: Re-add the Help button that was present in KDELibs4 version

Review Request #123939 - Created May 29, 2015 and submitted

Information
Alexander Potashev
kwidgetsaddons
master
b7c7246...
Reviewers
kdeframeworks
cfeck, ervin
The Help button was removed from KAssistantDialog while moving from
kdelibs4 to KF5.

The wizard dialog in KIPI plugin "Export to Flash" now has the same buttons as in its KDELibs4-based versions. Before this patch, the dialog did not have the Help button which I guess is important for KIPI plugins.

Christoph Feck
Alexander Potashev
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit dfe04ec7220713dea20123bc6a73add9b1a4e256 by Alexander Potashev to branch master.
David Faure

This commit added a Help button which .... does nothing. If the apps don't connect to it, the users end up with a broken Help button. I don't think it was a good idea .... but I also don't think we can fix it anymore, otherwise apps that relied on this and just called button(Help) would get a null ptr now and crash.

So, too late, but for the record, I think this was a bad idea ;-)

See also https://phabricator.kde.org/D1025

Loading...