Fix for "Some images rotated via EXIF are not rotated and appear in the wrong size" - BUG 343044

Review Request #123906 - Created May 26, 2015 and updated

Information
Lukas Hetzenecker
gwenview
master
343044
Reviewers
gwenview

I tracked down this bug and made the following observations:

It was caused by QTBUG-37946 ( https://bugreports.qt.io/browse/QTBUG-37946 ):

Starting with Qt 5.4 (which Ubuntu and Arch are shipping), QImage automatically checks if there is an Exif header present and rotates the images accordingly. - see this change: https://codereview.qt-project.org/#/c/98013/

But this behavior will be reverted in the soon released Qt 5.4.2, because it is backwards incompatible and breaks existing applications (like this one here ;) ) - see this change: https://codereview.qt-project.org/#/c/111398/

opened rotated and non-rotated images

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
This is a wrong check; you're looking at the version of Qt that the application was built against, not the ... Jan Kundrát Jan Kundrát
Martin Kyral
I'm just wondering: is there really a need of fixing the issue when it affects just builds against 2 minor versions of Qt? See https://git.reviewboard.kde.org/r/122873/

Apart from that, the change in this review most likely breaks rotation for some of the jpeg images. Try test with these: https://github.com/recurser/exif-orientation-examples.git

Third point is that IMHO no distro shall ship gwenview 5 now because (due to missing libkipi and libkdraw kf5 versions) it is missing support for viewing RAW files.
Jan Kundrát

   
lib/document/loadingdocumentimpl.cpp (Diff revision 1)
 
 

This is a wrong check; you're looking at the version of Qt that the application was built against, not the version which is in use at runtime.

Loading...