Show autohiding panels instantly

Review Request #123904 - Created May 25, 2015 and submitted

Information
Thomas Lübking
kwin
5.3?
Reviewers
kwin
graesslin, mart, thomaspfeiffer

summarized - I don't really know how autohides used to behave with plasma 4, but this probably makes sense (notably since it won't have major impact on the workspace like switching the VD or entering presentwindows/desktopgrid would)


  
Thomas Lübking
Thomas Pfeiffer
Martin Flöser
Thomas Lübking
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit c4140d6f4e5cd953023f2c078088d20a553ab875 by Thomas Lübking to branch Plasma/5.3.
Thomas Lübking

This "broke" the autotest.

Is this ok?

diff --git a/autotests/test_screen_edges.cpp b/autotests/test_screen_edges.cpp
index c217bc2..92d64d4 100644
--- a/autotests/test_screen_edges.cpp
+++ b/autotests/test_screen_edges.cpp
@@ -785,15 +785,7 @@ void TestScreenEdges::testClientEdge()
     event.same_screen_focus = 1;
     event.time = QDateTime::currentMSecsSinceEpoch();
     QVERIFY(s->isEntered(&event));
-    // first attempt should be pushed back and not activated
-    QCOMPARE(client.isHiddenInternal(), true);
-    QCOMPARE(Cursor::pos(), QPoint(1, 50));
-
-    // but if we wait a little bit it should trigger
-    QTest::qWait(160);
-    Cursor::setPos(0, 50);
-    event.time = QDateTime::currentMSecsSinceEpoch();
-    QVERIFY(s->isEntered(&event));
+    // autohiding panels shall activate instantly
     QCOMPARE(client.isHiddenInternal(), false);
     QCOMPARE(Cursor::pos(), QPoint(1, 50));

@@ -831,12 +823,6 @@ void TestScreenEdges::testClientEdge()
     QCOMPARE(client.isHiddenInternal(), true);
     Cursor::setPos(50, 0);
     s->check(QPoint(50, 0), QDateTime::currentDateTime());
-    QCOMPARE(client.isHiddenInternal(), true);
-    QCOMPARE(Cursor::pos(), QPoint(50, 1));
-    // and trigger
-    QTest::qWait(160);
-    Cursor::setPos(50, 0);
-    s->check(QPoint(50, 0), QDateTime::currentDateTime());
     QCOMPARE(client.isHiddenInternal(), false);
     QCOMPARE(Cursor::pos(), QPoint(50, 1));
  1. yeah seems right - that's just adjusting to the new behavior.

  2. http://commits.kde.org/kwin/3f8a8ea32afba42b436c1e274e00d52d98d5b0c2
    and
    http://commits.kde.org/kwin/be339d7ed33b804e869afb8f817d86b14b8487de

Loading...