Device notifier: Refresh the space indicator every 5 seconds.

Review Request #123817 - Created May 16, 2015 and submitted

Yoann Laissus

Previously, it was set to 0 so the space indicator was never refreshed.

Kai Uwe Broulik
Yoann Laissus
Kai Uwe Broulik
Yoann Laissus
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 44f957af3ef3d786012a70167e5cd170df0d5440 by Yoann Laissus to branch master.
Martin Klapetek

Fwiw, I think it would be much better if the dataengine actually signalled the disk space change rather than polling, then the applet could just handle the incoming "changed" signals -> less polling around.

  1. What mechanism do you think we can use to monitor disk space changes ? inotify/fanotify ?
    I'm afraid that the load would be higher with that approach. (with network mounts, for instance)

  2. It's fine if the dataengine polls for the space, but then the applet wouldn't have to unless the space actually changed. The dataengine can watch it anyhow and if the free space changes, it sends out the signal to which the applet would be connected and update its visualization.