[klipper] Ignore empty / blank entries

Review Request #123806 - Created May 15, 2015 and updated

Information
Patrick Eigensatz
plasma-workspace
master
159267, 192922
Reviewers
kde-workspace, usability
patrickeigensatz

[PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank entries

QString::isEmpty() is used to check if the string only consists of whitespace characters. If it does, the creation of the HistoryStringItem fails.


  

Issues

  • 2
  • 4
  • 0
  • 6
Description From Last Updated
Question: Compiled plasma-workspace using kdesrc-build --include-dependencies plasma-workspace, applied patch and compiled again. -> Build broken because g++ could not locate ... Patrick Eigensatz Patrick Eigensatz
you don't need to cast here, just do like in line 104: return HistoryItemPtr() Martin Flöser Martin Flöser
Martin Flöser
Patrick Eigensatz
Patrick Eigensatz
Patrick Eigensatz
Kai Uwe Broulik
Christoph Feck
Patrick Eigensatz
Patrick Eigensatz
Patrick Eigensatz
Martin Flöser
Patrick Eigensatz
Patrick Eigensatz
Patrick Eigensatz
Patrick Eigensatz
Patrick Eigensatz
Review request changed
Martin Flöser

   
klipper/historyitem.cpp (Diff revision 8)
 
 

you don't need to cast here, just do like in line 104:
return HistoryItemPtr()

Martin Flöser

I just gave the patch a try and it seems not to work. Although "Allow whitespace entries" is not checked I was able to get an entry with three new lines into the history.

  1. The patch looks like it only affects loading the history from disc (the datastream parameter smells a lot like this)

Loading...