Replace theme preview with a pixmap what shows all the backgrounds, consisntent with the one used for SystemSettings > Colors

Review Request #123480 - Created April 23, 2015 and submitted - Latest diff uploaded

Information
Rodrigo Fernandes
konsole
master
Reviewers
konsole, usability

Simplify theme preview

This patch replaces the theme preview with a similar one to System Settings > Colors.

Benefits:
Code reduction, lots of bespoke code removed
Consistency with existing ui presentation.
Displays the full color range as opposed to only foreground background

Drawbacks:
Static pixmax might not render as well in HiDPI screens.

Any feedback is greatly appreciated.
Please consider it for inclusion into Konsole.

Also this is my first review through RB, please mention anything I might has missed.

Regards,
Rodrigo

Files


Loading...