Replace theme preview with a pixmap what shows all the backgrounds, consisntent with the one used for SystemSettings > Colors
Review Request #123480 - Created April 23, 2015 and submitted
Simplify theme preview
This patch replaces the theme preview with a similar one to System Settings > Colors.
Code reduction, lots of bespoke code removed
Consistency with existing ui presentation.
Displays the full color range as opposed to only foreground background
Static pixmax might not render as well in HiDPI screens.
Any feedback is greatly appreciated.
Please consider it for inclusion into Konsole.
Also this is my first review through RB, please mention anything I might has missed.
Thanks for your patch!
However, I think it's more important to see the actual contrast for the majority case (which is plain text on background), so seeing what green on black, or white on blue, looks like makes the theme much more discernible than a bunch of seemingly random colors. Also, you might want to add the usability group to this review request.
Hi we have two discussions in the VDG about system settings.
1. System setting navigation (https://community.kde.org/KDE_Visual_Design_Group/System_Settings_Application)
2. Module layout
the Module layout HIG isn't finished yet. But the results are to have a header, description, preview and a selection area.
I think you made a good start to reduce the existing code and want to have an better user experience.
You offer an more detailed selection area. I'd prevere to have an selection area with less information (only the main color informations like background and text color) and a preview area with all informations.
Thanks for this work - I can commit this if you want to continue with your other changes. Note that on my screen the begginning A and ending 9 are cut off - perhaps because I have a bold font by default.