Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

Review Request #123479 - Created April 23, 2015 and submitted

Information
Milian Wolff
kcoreaddons
master
5096c8a...
Reviewers
kdeframeworks
dfaure, mutz, vkrause
The len in inotify_event includes nulls of the name. To prevent
them from being included in the QString/QByteArray we must filter
them manually with a recent Qt 5 dev build now. See also:

https://codereview.qt-project.org/#/c/106473/

REVIEW: 123479

I used the test and looked at the output and also ran it against a patched qtbase with this:

https://paste.kde.org/pmoue241d

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
Why this manual loop instead of strlen()? Does that mean that null characters in the middle are valid? Or, more ... Alex Richardson Alex Richardson
Milian Wolff
Milian Wolff
Matthew Dawson
Milian Wolff
Matthew Dawson
Aleix Pol Gonzalez
Alex Richardson
Milian Wolff
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit ff964c0c42202228348213e7d5c10f5611a9ee54 by Milian Wolff to branch master.
Loading...