Fix DecorationPalette loading when kdeglobals lacks WM group

Review Request #123320 - Created April 10, 2015 and submitted

Information
Mika Allan Rauhala
kwin
Plasma/5.3
51ed28c...
Reviewers
kwin

Currently, if a color scheme lacks the WM group, DecorationPalette doesn't load it so we can fallback to kdeglobals color scheme. If kdeglobals doesn't have WM group we get black decorations. This change will always load the kdeglobals color scheme even if it is missing WM group.

I looked at many color schemes and they all seem to have WM group so it is used for color scheme validation. However for some reason, it might be sometimes missing.


  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Thomas Lübking
Mika Allan Rauhala
Mika Allan Rauhala
Mika Allan Rauhala
Mika Allan Rauhala
Mika Allan Rauhala
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 1af7ed12204b45c9ccc53afbcc8217d3aa7154ce by Martin Gräßlin on behalf of Mika Allan Rauhala to branch Plasma/5.3.
Harald Sitter

It appears that there is a problem with this when there is no kdeglobals in $HOME (yet). What we are seeing is that if kwin is started before a kdeglobals is created it appearently still fails to get colors.
Notibly in a kubuntu ISO live session scenario a minimal session is spun up where kwin is pretty much the first kde tool run. At that time there probably is no kdeglobals (or at least none with the relevant data present [xdg one should always be present]). Resulting in a black window decoration -> http://i.imgur.com/qszt5Mf.jpg

Shutting down that session and starting it again does result in correct coloring. Removing .cache and .config however breaks it again. So my best guess is that it indeed fails to find the relevant data in kdeglobals rendering the colors still broken.

From what I can tell this primarily happens in VM envrionments (tested with vbox and kvm).

Example ISO exhibiting the problem:
http://pangea-data.s3.amazonaws.com/kci/images/amd64/20150417-1034/kubuntu-201504171034-amd64.iso

  1. https://git.reviewboard.kde.org/r/123399/

Loading...