Fix some more KConfig usage (wrt bug 340691)

Review Request #123288 - Created April 7, 2015 and submitted

Information
Hrvoje Senjan
plasma-desktop
Reviewers
plasma
davidedmundson, hein, mart

We only need to sync the changes to kde4 kdeglobals once users changes the defaults, hence only users KF5 kdeglobals need to be evaluated.
This workarounds (though the change is IMO correct anyway) the kconfig bug, as we can otherwise pass both local and systemwide kdeglobals into copyTo method.

W/o the patch i had both
BrowserApplication[$e]=chromium-browser.desktop (local adjustement)
BrowserApplication=firefox.desktop (distro branding)

in ~/.kde4/share/config/kdeglobals
now i have only locally adjusted value

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
This change makes it impossible for me to choose another browser than firefox on OpenSuSE, where /etc/xdg/kdeglobals says BrowserApplication=firefox. (comment ... David Faure David Faure
David Edmundson
Hrvoje Senjan
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 1c56fb2195511f4a2e5ff6e94d70dafedb11657e by Hrvoje Senjan to branch master.
Aleix Pol Gonzalez

Please make sure to use the bug field in reviewboard and CCBUG when committing changes related to bugs. It makes things much simpler to track afterwards.

David Faure

   

This change makes it impossible for me to choose another browser than firefox on OpenSuSE, where /etc/xdg/kdeglobals says BrowserApplication=firefox.

(comment added in https://bugs.kde.org/show_bug.cgi?id=340691#c9)

SimpleConfig means that upon saving, kconfig doesn't know it has to write
BrowserApplication[$d]
It does when I remove SimpleConfig, which fixes the bug for me.

This seems pretty logical to me, so this fix is clearly wrong. If something has to be fixed around some "copyTo" that the bug mentions, then it has to be fixed differently.

  1. Indeed. Though once you remove the SimpleConfig, the bug will be exposed again for kde4 kdeglobals. I.e. &config will point to both KF5 kdeglobals.

Loading...