Create breeze shadows unconditionally

Review Request #123284 - Created April 7, 2015 and submitted

Information
David Edmundson
breeze
master
Reviewers
plasma
hpereiradacosta

Breeze checks if shadows are supported by checking for a property on the
root window. This is set by kwin at some point after startup.

This leaves a gap for apps/plasmashell to start, determine shadows are
not supported and then never render them for the lifespan of that app.

It also can't handle window managers being replaced.

I spoke to Martin Grasslin who suggested just enabling shadows regardless, it's not a lot of overhead to load one set of pixmaps even if we don't end up using it. The alternative is waking up every app every time the root windows prop changes, which is arguably worse longterm.

Logged out and logged back in a lot, plasma always got shadows. Same for session restored apps.

started dolphin under openbox, switched to kwin, shadows \o/

Hugo Pereira Da Costa
David Edmundson
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 6641eb4e4387fc08e9142eb5e920b35dbf0258fd by David Edmundson to branch master.
Loading...