Avoid triggering bug 340691

Review Request #123281 - Created April 7, 2015 and submitted

Information
Hrvoje Senjan
plasma-desktop
Reviewers
plasma
davidedmundson, hein, mart

With Kdelibs4Migration we know exactly which file to modify, so it is both correct to use KConfig::SimpleConfig, and should help avoiding triggering the mentioned bug.
As similar fix was applied for bug 343583.

Changed the default browser in systemsettings5, the config got written in both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
I just noticed a compiler warning in this method: the "mode" argument isn't used. This part of the commit can't ... David Faure David Faure
Marco Martin
Hrvoje Senjan
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit b2fc8174d5733fe3b051f839944870b4f51b8c52 by Hrvoje Senjan to branch master.
David Faure

   
kcms/migrationlib/kdelibs4config.h (Diff revision 1)
 
 

I just noticed a compiler warning in this method: the "mode" argument isn't used. This part of the commit can't possibly have changed anything, then.
Either it should actually be used, or it should be removed. Otherwise it's just confusing, as this patch shows....

  1. You're right. Furthermore, the bug is about the source, not the target.

Loading...