Add color tab feature

Review Request #123279 - Created April 6, 2015 and submitted

Information
Sebastien Speierer
kdevplatform
master
269704
Reviewers
kdevelop

This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
This feature was asked by several users on the KDE bugtracking system.

I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.

Files


Issues

  • 29
  • 24
  • 0
  • 53
Description From Last Updated
What if my color scheme's text color isn't black? This should retrieve the existing tab text color and return that ... Andreas Pakulat Andreas Pakulat
Hm, isn't there a way to make the shell do the determination and then tell sublime ui via a (new?) ... Andreas Pakulat Andreas Pakulat
This is a bad idea, first of all entryList already allows you to filter so you can easily get a ... Andreas Pakulat Andreas Pakulat
hardcoded color here. Andreas Pakulat Andreas Pakulat
Another hardcoded 'black' color, should ask the color scheme or the tabbar for its default color. Andreas Pakulat Andreas Pakulat
What if that's not enough colors? Let's come up with a small algorithm that ensures we will get proper distinguishable ... Aleix Pol Gonzalez Aleix Pol Gonzalez
Fix whitespaces. Aleix Pol Gonzalez Aleix Pol Gonzalez
did you test this with a dark color scheme? I guess it won't look good and you'll need to use ... Milian Wolff Milian Wolff
this new feature should be off by default Milian Wolff Milian Wolff
wrong indentation Milian Wolff Milian Wolff
unrelated change. tip: try "git checkout -p" to interactively undo such hunks Milian Wolff Milian Wolff
again, unrelated Milian Wolff Milian Wolff
why queued connections here and below? Milian Wolff Milian Wolff
remove the space after the connect( Milian Wolff Milian Wolff
here and below: add space after if and before the { also make the setting off by default please. Milian Wolff Milian Wolff
join with next line Milian Wolff Milian Wolff
} else { Milian Wolff Milian Wolff
move * next to typename Milian Wolff Milian Wolff
move * next to typename, i.e. remove space after IDocument Milian Wolff Milian Wolff
off by default. can we have this in a central function maybe to share the code? Milian Wolff Milian Wolff
join with next line, also move * next to typename Milian Wolff Milian Wolff
unrelated change Milian Wolff Milian Wolff
join with next line Milian Wolff Milian Wolff
join with next two lines Milian Wolff Milian Wolff
off by default please Milian Wolff Milian Wolff
unrelated changes Milian Wolff Milian Wolff
space after for Milian Wolff Milian Wolff
space after for Milian Wolff Milian Wolff
style: if (...) { ... } Milian Wolff Milian Wolff
Andreas Pakulat
Andreas Pakulat
Aleix Pol Gonzalez
Kevin Funk
Sebastien Speierer
Milian Wolff
Sebastien Speierer
Sebastien Speierer
Sebastien Speierer
Milian Wolff
Sebastien Speierer
Milian Wolff
Sebastien Speierer
Sebastien Speierer
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 179a03ea8f6bc171f747eb2eb7210d17533f3e4c by Kevin Funk to branch master.
Loading...