Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

Review Request #123274 - Created April 6, 2015 and submitted

Information
Bernhard Friedreich
kdeplasma-addons
master
156fbed...
Reviewers
plasma

Added tab "General" and "Appearance" in the config ui

General contains the bits about command execution after the timer has completed
Appearance contains the ability to hide seconds and showing the title

The configuration option for showing the title is a bit buggy (again)
This bugreport explains the wrong scaling of the title: 304923

I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start)

[Edit 1]: updated to use QProcess
[Edit 2]: renamed General to Advanced and moved it down to make "Appearance" the default tab on opening
[Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox
[Edit 4]: fixed many things mentioned by Kai Uwe Broulik

Tested using plasmashell directly and using plasmoidviewer

Files


Issues

  • 0
  • 17
  • 0
  • 17
Description From Last Updated
Bernhard Friedreich
David Edmundson
Bernhard Friedreich
Bernhard Friedreich
David Edmundson
Bernhard Friedreich
Bernhard Friedreich
Bernhard Friedreich
Kai Uwe Broulik
Bernhard Friedreich
David Edmundson
Bernhard Friedreich
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 57aeac6278d8085b481850d62eb2f2ad8109a316 by Bernhard Friedreich to branch master.

Thanks for your review :)

Loading...