Fix exports and avoid using sources already linked on tests.

Review Request #123270 - Created April 5, 2015 and discarded

Information
Andrius da Costa Ribas
dolphin
Reviewers
dolphin, kdewin

When bringing dolphinvcs to the repo, dolphinprivate exports got messed up. This patch fixes it and also fixes building the tests by not using the sources already exported dolphinprivate, which is linked to those tests.

Built using MSVC2013. Dolphin works mostly fine. Three tests still do not pass but seem unrelated to this fix.

--- TEST OUTPUT ---

Running tests...
Test project V:/build/kde/dolphin/work/msvc2013-RelWithDebInfo-master
    Start 1: kitemsettest
1/9 Test #1: kitemsettest .........................   Passed    0.22 sec
    Start 2: kitemrangetest
2/9 Test #2: kitemrangetest .......................   Passed    0.03 sec
    Start 3: kitemlistselectionmanagertest
3/9 Test #3: kitemlistselectionmanagertest ........   Passed    0.19 sec
    Start 4: kitemlistcontrollertest
4/9 Test #4: kitemlistcontrollertest ..............***Failed    5.32 sec
    Start 5: kfileitemlistviewtest
5/9 Test #5: kfileitemlistviewtest ................***Failed    5.37 sec
    Start 6: kfileitemmodeltest
6/9 Test #6: kfileitemmodeltest ...................***Failed  175.96 sec
    Start 7: kitemlistkeyboardsearchmanagertest
7/9 Test #7: kitemlistkeyboardsearchmanagertest ...   Passed    0.31 sec
    Start 8: kstandarditemmodeltest
8/9 Test #8: kstandarditemmodeltest ...............   Passed    0.18 sec
    Start 9: viewpropertiestest
9/9 Test #9: viewpropertiestest ...................   Passed    0.20 sec

67% tests passed, 3 tests failed out of 9

Total Test time (real) = 188.13 sec

The following tests FAILED:
          4 - kitemlistcontrollertest (Failed)
          5 - kfileitemlistviewtest (Failed)
          6 - kfileitemmodeltest (Failed)
Errors while running CTest
NMAKE : fatal error U1077: 'v:\dev-utils\bin\ctest.exe' : return code '0x8'
Stop.

v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>bin\kitemlistcontrollertest.exe

v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>********* Start testing of KItemListControllerTest *********
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-llp64 shared (dynamic) release build; by MSVC 2013)
QWARN  : KItemListControllerTest::initTestCase() "Trying to convert empty KLocalizedString to QString."
QWARN  : KItemListControllerTest::initTestCase() "URL cannot be listed
file:///C:/Users/Andrius-pc/AppData/Local/Temp/kitemlistcontrollertest-1XkOA3"
QWARN  : KItemListControllerTest::initTestCase() Icon theme "oxygen" not found.
QDEBUG : KItemListControllerTest::initTestCase() kf5.kiconthemes: Couldn't find current icon theme, falling back to default.
QWARN  : KItemListControllerTest::initTestCase() Icon theme "oxygen" not found.
QWARN  : KItemListControllerTest::initTestCase() Error: standard icon theme "oxygen" not found!
FAIL!  : KItemListControllerTest::initTestCase() 'spyDirectoryLoadingCompleted.wait()' returned FALSE. ()
q:\dolphin\src\tests\kitemlistcontrollertest.cpp(142) : failure location
PASS   : KItemListControllerTest::cleanupTestCase()
Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KItemListControllerTest *********

v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>bin\kfileitemlistviewtest.exe

v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>********* Start testing of KFileItemListViewTest *********
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-llp64 shared (dynamic) release build; by MSVC 2013)
PASS   : KFileItemListViewTest::initTestCase()
QWARN  : KFileItemListViewTest::testGroupedItemChanges() "URL cannot be listed
file:///C:/Users/Andrius-pc/AppData/Local/Temp/kfileitemlistviewtest-1XkOA3"
FAIL!  : KFileItemListViewTest::testGroupedItemChanges() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemlistviewtest.cpp(99) : failure location
PASS   : KFileItemListViewTest::cleanupTestCase()
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KFileItemListViewTest *********

v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>bin\kfileitemmodeltest.exe

v:\build\kde\dolphin\work\msvc2013-RelWithDebInfo-master>********* Start testing of KFileItemModelTest *********
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-llp64 shared (dynamic) release build; by MSVC 2013)
PASS   : KFileItemModelTest::initTestCase()
PASS   : KFileItemModelTest::testDefaultRoles()
FAIL!  : KFileItemModelTest::testDefaultSortRole() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(154) : failure location
PASS   : KFileItemModelTest::testDefaultGroupedSorting()
FAIL!  : KFileItemModelTest::testNewItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(174) : failure location
FAIL!  : KFileItemModelTest::testRemoveItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(188) : failure location
FAIL!  : KFileItemModelTest::testDirLoadingCompleted() 'loadingCompletedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(208) : failure location
FAIL!  : KFileItemModelTest::testSetData() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(252) : failure location
FAIL!  : KFileItemModelTest::testSetDataWithModifiedSortRole(Index 0: Rating 3) 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location
FAIL!  : KFileItemModelTest::testSetDataWithModifiedSortRole(Index 0: Rating 5) 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location
FAIL!  : KFileItemModelTest::testSetDataWithModifiedSortRole(Index 0: Rating 8) 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location
FAIL!  : KFileItemModelTest::testSetDataWithModifiedSortRole(Index 2: Rating 1) 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location
FAIL!  : KFileItemModelTest::testSetDataWithModifiedSortRole(Index 2: Rating 3) 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location
FAIL!  : KFileItemModelTest::testSetDataWithModifiedSortRole(Index 2: Rating 5) 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(313) : failure location
FAIL!  : KFileItemModelTest::testChangeSortRole() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(363) : failure location
FAIL!  : KFileItemModelTest::testResortAfterChangingName() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(405) : failure location
FAIL!  : KFileItemModelTest::testModelConsistencyWhenInsertingItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(442) : failure location
FAIL!  : KFileItemModelTest::testItemRangeConsistencyWhenInsertingItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(481) : failure location
FAIL!  : KFileItemModelTest::testExpandItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(539) : failure location
FAIL!  : KFileItemModelTest::testExpandParentItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(669) : failure location
FAIL!  : KFileItemModelTest::testMakeExpandedItemHidden() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(741) : failure location
FAIL!  : KFileItemModelTest::testRemoveFilteredExpandedItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(784) : failure location
FAIL!  : KFileItemModelTest::testSorting() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(845) : failure location
FAIL!  : KFileItemModelTest::testIndexForKeyboardSearch() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(959) : failure location
FAIL!  : KFileItemModelTest::testNameFilter() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1009) : failure location
PASS   : KFileItemModelTest::testEmptyPath()
FAIL!  : KFileItemModelTest::testRefreshExpandedItem() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1072) : failure location
FAIL!  : KFileItemModelTest::testRemoveHiddenItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1105) : failure location
FAIL!  : KFileItemModelTest::collapseParentOfHiddenItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1153) : failure location
FAIL!  : KFileItemModelTest::removeParentOfHiddenItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1203) : failure location
FAIL!  : KFileItemModelTest::testGeneralParentChildRelationships() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1256) : failure location
FAIL!  : KFileItemModelTest::testNameRoleGroups() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1343) : failure location
FAIL!  : KFileItemModelTest::testNameRoleGroupsWithExpandedItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1411) : failure location
FAIL!  : KFileItemModelTest::testInconsistentModel() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1448) : failure location
FAIL!  : KFileItemModelTest::testChangeRolesForFilteredItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1504) : failure location
PASS   : KFileItemModelTest::testChangeSortRoleWhileFiltering()
FAIL!  : KFileItemModelTest::testRefreshFilteredItems() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1597) : failure location
FAIL!  : KFileItemModelTest::testCollapseFolderWhileLoading() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1657) : failure location
FAIL!  : KFileItemModelTest::testCreateMimeData() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1630) : failure location
FAIL!  : KFileItemModelTest::testDeleteFileMoreThanOnce() 'itemsInsertedSpy.wait()' returned FALSE. ()
q:\dolphin\src\tests\kfileitemmodeltest.cpp(1731) : failure location
PASS   : KFileItemModelTest::cleanupTestCase()
Totals: 6 passed, 35 failed, 0 skipped, 0 blacklisted
********* Finished testing of KFileItemModelTest *********
Emmanuel Pescosta
Andrius da Costa Ribas
Review request changed

Status: Discarded

Change Summary:

Since this is from one year ago (and shame on me I hadn't submitted), I'm reworking this onto a new patch.

Loading...