dolphin: Navigate to parent folder selects child folder

Review Request #123253 - Created April 4, 2015 and submitted

Information
Gregor Mi
dolphin
master
335616
127111
Reviewers
dolphin
emmanuelp

This is a first working implementation of the feature suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder selects child folder".

In short, this is what is does: Whenever the dolphin view is initialized to show the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is successful, then the common child (in this example: "/home/x/test/documents/") folder item will be selected and scrolled into view.

  • unit test passes
  • Played around with dolphin: enter URL manually, navigate via click in the item view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, Alt+up, Backspace

2016-02-18:
There is now a difference in selection behaviour when using history buttons vs. direct url entry:

  • history buttons: mark the item as current instead of restoring the previous selection
  • direct url entry: the child item is marked as current and selected

I personally prefer the selection because it is clearly visible. If it is ok I would try to adapt the history behaviour accordingly.
Update: I just saw that the "File Open" dialog does not do any selection at all if navigated back via history buttons. I'll postpone further action on this side issue for now.

Issues

  • 0
  • 17
  • 0
  • 17
Description From Last Updated
Gregor Mi
Gregor Mi
Gregor Mi
Frank Reininghaus
Frank Reininghaus
Gregor Mi
Gregor Mi
Gregor Mi
Gregor Mi
Emmanuel Pescosta
Gregor Mi
Gregor Mi
Emmanuel Pescosta
Frank Reininghaus
Frank Reininghaus
Gregor Mi
Gregor Mi
Gregor Mi
Gregor Mi
Gregor Mi
Emmanuel Pescosta
Gregor Mi
Emmanuel Pescosta
Gregor Mi
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 3749b5552729b434655ddc950b120bb14fe888c7 by Emmanuel Pescosta on behalf of Gregor Mi to branch master.
Loading...