Fix assert by not calling onto an empty path for setOfflineWebApplicationCachePath()

Review Request #123222 - Created April 2, 2015 and submitted

Information
Aleix Pol Gonzalez
libksysguard
Reviewers
plasma
If we pass an empty string, we end up asserting here:
qt5/qtwebkit/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:372

#0  0x00007fffed178512 in WTFCrash () at /home/kde-devel/frameworks/qt5/qtwebkit/Source/WTF/wtf/Assertions.cpp:345
#1  0x00007fffec78e161 in WebCore::ApplicationCacheStorage::setCacheDirectory (this=0xa07a70, cacheDirectory=...) at /home/kde-devel/frameworks/qt5/qtwebkit/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:372
#2  0x00007fffeb5085c5 in QWebSettings::setOfflineWebApplicationCachePath (path="") at /home/kde-devel/frameworks/qt5/qtwebkit/Source/WebKit/qt/Api/qwebsettings.cpp:1142
#3  0x00007ffff79087bd in ScriptingHtmlDialog::ScriptingHtmlDialog (this=0x969720, parent=0x744080) at /home/kde-devel/frameworks/libksysguard/processui/scripting.cpp:64

So we just don't set an empty string.

Now I don't get a crash anymore.

David Edmundson
Aleix Pol Gonzalez
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 18e151f5c34cb7dabdc6c777cb79a8694744cab4 by Aleix Pol to branch master.
Loading...