Save bookmarks when adding them via the context menu

Reviews
Diff

- Download Diff

Information
Submitter:	Emmanuel Pescosta
Repository:	kde-baseapps
Branch:	Applications/15.04
Bugs:	345347
Depends On:
Reviewers
Groups:	dolphin
People:

Description

Save bookmarks when adding them via the context menu.

We have to call PlacesItemModel::saveBookmarks explicitly since https://git.reviewboard.kde.org/r/122640/
Maybe we should create a bookmarks service in future to encapsulate it.

FIXED-IN: 15.04
BUG: 345347

Testing Done

"Add to places" works in the item and viewport context menu

Expand All
Collapse All

Ship it!

Looks good!
Encapsulating the access to the bookmarks file is probably a good idea. Whenenver I had to work with the "Places" code, I also thought that having a wrapper class (maybe in KIO?) that provides a simple API to manipulate the "Places" would be great.

Status: Closed (submitted)

Change Summary:

Submitted with commit fba5dd58a55e191a3368cc85735826c2b9e18a8b by Emmanuel Pescosta to branch master.

You have a pending review.

Review Board 2.5.15

Screenshots

Files

Status: Closed (submitted)

Change Summary: