[gwenview] Make tests optional

Review Request #122983 - Created March 16, 2015 and discarded

Information
Andreas Sturmlechner
gwenview
master
Reviewers
gwenview

There was already a check performed in tests/auto to conditionally build them if Qt5Test_FOUND - so I moved that up one directory to expand it to tests/manual as well. find_package(Qt5Test) is already done in root CMakeLists.txt (and made optional as seen in kwin).

Built with and without tests. I am currently not able to get a success everywhere, but the patch doesn't change anything about it.

Also, something to be done about the following? The dependency target "buildtests" of target "check" does not exist.

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
Instead of doing a return() from tests/CMakeLists.txt it would be nicer to change the root CMakeLists.txt to wrap the add_subdirectory(tests) ... Aurélien Gâteau Aurélien Gâteau
Aurélien Gâteau
Andreas Sturmlechner
Review request changed

Status: Discarded

Loading...