Preserve translation domain when merging KXmlGui files

Review Request #122937 - Created March 14, 2015 and submitted

Information
Chusslove Illich
kxmlgui
Reviewers
kdeframeworks
dfaure, lliehu

When two .rc documents that specify different translation domains are merged, only one of the two domains will appear in the merged document. This breaks translation of text elements under the dropped domain. To fix it, the top domain attribute (or the application domain) should be propagated to each text element before merging. Then, at the moment of translation, the local domain attribute should take priority over the top attribute (or the application domain).

This fix also works if the merged document is written out and later loaded. Hence the local translation domain attribute is added to schemas as well.

Reference bug report: https://bugs.kde.org/show_bug.cgi?id=342976

Tested an application that previously had an untranslated menu title due to this issue, now it is translated.

Lasse Liehu
David Faure
Chusslove Illich
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 2920e946c24d78eb0b6b3038a9cc38a8897ce4ac by Chusslove Illich (?????? ????) to branch master.
Loading...