QML-only KCM base

Review Request #122886 - Created March 10, 2015 and submitted

Information
Marco Martin
kdeclarative
122888, 122887
Reviewers
kdeframeworks, plasma

This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly.
it loads a qml file that then will be able to access its instance as "kcm" or as the "KCM" attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible).
They will be loaded in systemsettings by review 122887


  

Issues

  • 7
  • 0
  • 0
  • 7
Description From Last Updated
I don't particularly like the KDeclarative namespace here since the library is called QuickAddons, but unfortunately that name is terrible, ... Marco Martin Marco Martin
I didn't test things that need authentication yet (if some good soul ports a module that uses it would be ... Marco Martin Marco Martin
this should mention packages somewhere. David Edmundson David Edmundson
This documentation tells me nothing, and I'm not sure what this does from the method name. David Edmundson David Edmundson
I guess you copy and pasted all these. KConfigXT isn't relevant at all here. David Edmundson David Edmundson
when combined with your other KCModule patch you have a crash. From KCModule docs: This sets the KAboutData returned by ... David Edmundson David Edmundson
you need also KF5::Auth as public, the new public header has a kauthaction include Hrvoje Senjan Hrvoje Senjan
Marco Martin
Marco Martin
David Edmundson
Hrvoje Senjan
Marco Martin
David Edmundson
Marco Martin
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 119510b653a3c02c758d055db2c10db73461b905 by Marco Martin to branch master.
Loading...