Use the new KDecoration API for getting additional colors

Review Request #122884 - Created March 10, 2015 and submitted

Information
Mika Allan Rauhala
breeze
master
122882
6dc0f3b...
Reviewers
kwin, plasma

Breeze::ColorSettings now uses KDecoration2::DecoratedClient::color() for getting additional colors instead of reading them from kdeglobals. This allows per window color schemes with custom titlebar colors to work.


  
Mika Allan Rauhala
Mika Allan Rauhala
Mika Allan Rauhala
Mika Allan Rauhala
Hugo Pereira Da Costa
Mika Allan Rauhala
Mika Allan Rauhala
Mika Allan Rauhala
Mika Allan Rauhala
Mika Allan Rauhala
Mika Allan Rauhala
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit daa39c6a6b9f2fe5de276065d145b550ce216c5b by Hugo Pereira Da Costa to branch master.
Siddhartha Sahu

Hey. This commit breaks breeze decoration for me. The titlebar is completely black for all windows and also in the "Windows Decoration" kcm list.
Titlebar buttons customization also does not work.

Reverting this commit fixes the bug.

  1. I rather doubt that this commit can turn it black. Please ensure that you have an up to date build of kwin, too.

  2. Hi Martin,

    I have plasma 5 built from git using kdesrc-build (updated almost everyday).

    Just to make sure, I compiled and installed breeze master again. KCM shows black. Revert commit, install, KCM shows everything ok.

  3. Kwin info: https://paste.kde.org/phjgqezjg

  4. Could you check if ~/.config/kdeglobals has [WM] group? Lack of it might cause DecorationPalette to ignore the color scheme, a good thing with a broken custom color scheme, but not with a default one.

  5. Could you try https://git.reviewboard.kde.org/r/123320/?

  6. I assume he's no kdeglobals at all.

  7. I do have kdegloabls, but no WM group in it.
    And yes, RR 123320 fixes the bug :)

Loading...