Add timedated support into the clock KCM as an optional dependency

Review Request #122400 - Created Feb. 3, 2015 and submitted

Information
David Edmundson
plasma-desktop
master
Reviewers
plasma

The current time setting helper is incredibly broken.

It manually tries to run a range of NTP utilities, all of which are
deprecated.

We can just call timedated directly and cut out the middleman as it has
uses polkit anyway.

This is currently an optional dependency, and the original helper still
exists. It makes the code messy, but we have users to support for now.

Finding timedated is an cmake option rather than querying for systemd
libs to make it easier for those deploying shims, such as BSD.

(code is in two commits, first abstracting the saving from the dtime class; then adding in the second save mechanism)


  

Issues

  • 3
  • 3
  • 1
  • 7
Description From Last Updated
does it need to be a blocking dbus call? Any chance in getting it use a watcher? Martin Flöser Martin Flöser
suggestion: move it into the dbus reply check Martin Flöser Martin Flöser
This part can be async. You can do it by chain two different callback if it need to be done ... Xuetian Weng Xuetian Weng
Martin Klapetek
Martin Flöser
Martin Flöser
Martin Flöser
Xuetian Weng
David Edmundson
David Edmundson
Lukáš Tinkl
David Edmundson
Review request changed

Status: Closed (submitted)

Loading...