Add support to opus files in TagLibExtractor

Review Request #122324 - Created Jan. 29, 2015 and submitted

Information
Juan Palacios
kfilemetadata
Reviewers
vhanda

This patch add support to read the metadata contained in opus files.

The patch in review https://git.reviewboard.kde.org/r/122323/ must be applied before this one.


  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Vishesh Handa
Vishesh Handa
Juan Palacios
Review request changed

Status: Closed (submitted)

Hrvoje Senjan

   
src/extractors/taglibextractor.cpp (Diff revision 1)
 
 

this raises required taglib version to 1.9, as opus is not supported earlier. or CMakeLists should probably be adjusted, or something like https://projects.kde.org/projects/extragear/multimedia/amarok/repository/revisions/abd5c3ff4051c77075b39f827d58045f100a5be3

  1. TagLib 1.9 was released in October, 2013. I think that add more code to support older versions of TagLib that probably (almost) nobody uses now (in the use context of kfilemetadata5) is a bad idea.
    So my vote is to raise required TagLib version to 1.9

    Vishesh, what do you think about this? How can be done? Just changing find_package(Taglib) to find_package(Taglib 1.9) in CMakeLists.txt will do the work?

  2. ubuntu 13.10 & openSUSE 13.1 have < 1.9 (speaking of real-world-support). i don't mind any solution, just wanted to indicate that this doesn't work with older taglib ;-)

  3. I'm all for increasing the taglib version.

    Distros can/should update their taglib.

  4. Fixed in commit 750e508

Loading...