port kcminit away from kdelibs4support

Review Request #122270 - Created Jan. 27, 2015 and submitted

Information
Nick Shaforostoff
plasma-workspace
master
Reviewers
kde-workspace
apol, graesslin, lukas

Now kcminit is linked with less libraries -> startup time improved

I also suggest always setting KDE_MULTIHEAD=true to eliminate ini file access during startup and to be able to stop linking against QtGui

compiled, ran 'kcminit --list' and kcminit AAA

Issues

  • 0
  • 6
  • 0
  • 6
Description From Last Updated
Nick Shaforostoff
Martin Flöser
Nick Shaforostoff
Martin Flöser
Nick Shaforostoff
Martin Flöser
Nick Shaforostoff
Review request changed

Status: Closed (submitted)

Martin Flöser

I'm surprised that you pushed the change although the review was not finished and you hadn't a shipit on any of the versions.

  1. Nick, though it does not seem as if you had introduced it, the "QGuiApplication::screens().count() > 1" check is, as has been pointed out in this review several times, still wrong for sure.
    Do you intend to keep working on this code? (to get rid of QGuiApplication and perhaps the ini read)

  2. sorry, should i revert the commit?

    yes, i intend to create a new review request with 'QGuiApplication::screens().count() > 1' replacement using xcb routines.

  3. i had a look at kcminit from KDE4 branch and indeed it used ScreenCount(QX11Info::display()), which can be substituted simply via xcb according to http://xcb.freedesktop.org/xlibtoxcbtranslationguide/

Loading...