[KUnitConversion] Currency: Fetch the currency file properly

Review Request #122183 - Created Jan. 21, 2015 and discarded

Information
Vishesh Handa
kunitconversion
340819
Reviewers
kdeframeworks

Currency: Fetch the currency file properly

Properly run an event loop and wait for the file to be fetched.

Also add a test to make sure currency conversion is working.

This patch also contains -
https://git.reviewboard.kde.org/r/122182/
https://git.reviewboard.kde.org/r/122181/
* https://git.reviewboard.kde.org/r/122180/

This is because reviewboard refuses to upload only a part of the diff. Please only look at currency.cpp w.r.t the EventLoop.

Test now passes.

Issues

  • 2
  • 5
  • 1
  • 8
Description From Last Updated
Ouch. Hello unexpected reentrancy. If this code is async, it should provide a Job API instead of masquerading under a ... David Faure David Faure
missing error handling on the open() call [was there before this patch] David Faure David Faure
David Faure
David Faure
Vishesh Handa
David Faure
Vishesh Handa
David Faure
Vishesh Handa
Vishesh Handa
David Faure
Albert Astals Cid
Vishesh Handa
Review request changed

Status: Discarded

Change Summary:

The same bug was fixed meanwhile by https://git.reviewboard.kde.org/r/127251/ (dfaure) (I'll salvage the unittest though)

Loading...