Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33
Review Request #122072 - Created Jan. 15, 2015 and submitted
| Information | |
|---|---|
| Eike Hein | |
| libksysguard | |
| Plasma/5.2 | |
| 342837 | |
| Reviewers | |
| kdeframeworks, plasma | |
| graesslin, gregormi, mart, sitter | |
3f9ecc33 in libksysguard.git added a new data member to the publically-exported Process class, which doesn't have a d-ptr. This is a BIC change, and currently causing lots of crashes for Plasma users (see bug 342837). This diff bumps the SO version for the processcore library - and for all the other libs installed by libksysguard, since I didn't want to bifurcate the version handling in the build system and make it much more complicated.
+1 from me
+1
Makes sense to me :)
+1 from here too ()would like people that did the change in sysguard taking a look at it as well tough)
First of all, thanks Eike for the quick patch. I cannot comment much on the coding details of your change since this is new stuff for me. But my apologies for introducing this inconvenience.
Though I am not the maintainer but the causer of the bug I'll gladly give a ShipIt. :)
A related thing is with https://git.reviewboard.kde.org/r/121831/: This also causes a BIC change and would therefore also require an SOVERSION bump. I am wondering if another SOVERSION change would be good regarding having stable KDE APIs. Is there a certain point in time when APIs like this one should not change anymore?