Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

Review Request #121931 - Created Jan. 8, 2015 and submitted

Information
Milian Wolff
kitemmodels
master
2807b22...
Reviewers
kdeframeworks
skelly

The upstream commit f96baeb75fc36a41d2b08f880536cee5a8041e79
with the title:

QSortFilterProxyModel: honor the roles parameter of dataChanged

changes the signature of the private _q_sourceDataChanged slot
of QSortFilterProxyModel. I talked to Peppe and he told me to just
use the new signature from Qt 5.5 and onwards. Note that the vector
of roles was present in the dataChanged signal from 5.0 onwards
already. It was simply ignored by QSFPM so far.

Indeed, this patch fixes the following crash on Kate startup for me:

QMetaObject::invokeMethod: QMetaObject::invokeMethod: No such method
KRecursiveFilterProxyModel::_q_sourceDataChanged(QModelIndex,QModelIndex)
Candidates are:
&nbsp; _q_sourceDataChanged(QModelIndex,QModelIndex,QVector<int>)
ASSERT: "success" in file
kf5/src/frameworks/kitemmodels/src/krecursivefilterproxymodel.cpp, line 55

sadly, there are no unit tests for this. but I can use Kate again without crashes and there are no warnings on startup either.

Milian Wolff
Milian Wolff
Milian Wolff
Kevin Funk
Milian Wolff
Milian Wolff
Review request changed

Status: Closed (submitted)

Loading...