kconf_update needs to launch update for kf5 application not for kde4 application.

Review Request #121797 - Created Jan. 3, 2015 and submitted

Information
Laurent Montel
kconfig
master
Reviewers
dfaure, mdawson

This patch is necessary because:
When we use kf5 + kde4 application, kconf_update which launchs at the start when we launch kde.
But it will migrate some config file, for example it will show that we need to migrate konversation
so it will create a konversationrc in .config/

But when we launch konversation there is a kdelibs4migrator which wants to migrate settings and config in .config
but it shows a konversationrc in .config so it will never migrate and we will lose all settings.

So we can force to remove all .upd in kf5 but it will not fix problem during migration or when we have kde4 application
install in same directory as kf5.

So now I force for each upd file to have a "Version=5" so kconf_update (kf5) will migrate just kf5 upd file and it will fix my bugs.

I updated unittest.

Unit test adapted for this change.

Issues

  • 0
  • 10
  • 0
  • 10
Description From Last Updated
Laurent Montel
David Faure
Laurent Montel
David Faure
Laurent Montel
David Faure
Matthew Dawson
Matthew Dawson
Laurent Montel
Review request changed

Status: Closed (submitted)

Martin Flöser

I just got noticed about this change and I think this is a bad solution. This breaks existing behavior and I would even go so far to say that it breaks the stable API promise (yes I consider the udp format as API). The udp files shipped with Plasma 5.2 will stop working after an update to the next framework release. That's quite uncool.

  1. While I agree it is not the ideal solution, I was unable to think up anything better (that is why I took so long to reply initially). I'll keep thinking on the problem, but if you have any suggestions in the meantime I'm happy to hear them.

Loading...