implement proper multi-arch dependency resolution
Review Request #121730 - Created Dec. 28, 2014 and updated
| Information | |
|---|---|
| Harald Sitter | |
| libqapt | |
| master | |
| 330446, 330449, 330450, 330451 | |
| e5c54f8... | |
| Reviewers | |
| kubuntu, libqapt | |
| apol, mstemle | |
implement proper multi-arch dependency resolution
using an exciting amount of spaghetti!
BUG: 330451
BUG: 330450
BUG: 330449
BUG: 330446
all test cases outlined in the bug reports
I am not sure existing functionality regressed, it's all a bit nasty and the lack of apt-mocing for autottesting doesn't help the cause :/
Issues
- 3
- 2
- 0
- 5
| Description | From | Last Updated |
|---|---|---|
| Maybe it could go into a separate function? |
Aleix Pol Gonzalez
|
|
| Can you at least break this switch (or the whole loop) into a smaller separate function? |
Aleix Pol Gonzalez
|
|
| qWarning()? |
Aleix Pol Gonzalez
|
Summary: |
|
|---|
-
utils/qapt-deb-installer/DebInstaller.cpp (Diff revision 1) -
QStringLiteral("%1...
-
utils/qapt-deb-installer/DebInstaller.cpp (Diff revision 1) -
I wouldn't add debug output there. It's of little use.
Change Summary:
refine as per review
reduce debug to one line that is only used when we fail to resolve a dependency as this is handy information to easily get when a user has a dependency problem for no apparent reason.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+197 -33) |
The code is quite scary, I don't feel like I can give a +1 to that.
If you added some testing, I could add a sneaky ship it and then we blame it on the test if it doesn't work.
-
utils/qapt-deb-installer/DebInstaller.cpp (Diff revision 2) -
Maybe it could go into a separate function?
-
utils/qapt-deb-installer/DebInstaller.cpp (Diff revision 2) -
Can you at least break this switch (or the whole loop) into a smaller separate function?
-
utils/qapt-deb-installer/DebInstaller.cpp (Diff revision 2) -
qWarning()?