Make KDEInstallDirs provide KDE_INSTALL_* variables.

Review Request #121646 - Created Dec. 23, 2014 and submitted

Information
Alex Merry
extra-cmake-modules
master
b160b8d...
Reviewers
extracmakemodules
skelly

Creating variables whose names start with CMAKE_ is a bad idea for
modules distributed outside CMake itself. Since the module is called
KDEInstallDirs, having a KDE_INSTALL_ prefix for the variables is clear
and intuitive.

Both CMAKE_INSTALL_* variables and the older KDELibs4-compatible
variables are provided, unless KDE_INSTALL_DIRS_NO_DEPRECATED is set to
TRUE before the module is included. Even then, the CMAKE_INSTALL_*
variables provided by the GNUInstallDirs module will still be set and
understood (for compatibility with that module), unless
KDE_INSTALL_DIRS_NO_CMAKE_VARIABLES is set to TRUE.


Refactor KDEInstallDirs tests.

make test passes. I will do a rebuild of frameworks soon.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
David Faure
Alex Merry
Review request changed

Status: Closed (submitted)

Hrvoje Senjan

   
kde-modules/KDEInstallDirs.cmake (Diff revision 2)
 
 

typo? should be uppercase, no?

  1. Good spot, thanks!

Loading...