Switch away from libarchive deprecated functions
Review Request #121342 - Created Dec. 3, 2014 and submitted
This patch replaces the deprecated
libarchivefunctions used in
libarchivehandler.cppwith their replacements.
Quick reference: https://github.com/libarchive/libarchive/wiki/ManPageLibarchiveChanges3#Deprecated_Symbols
After compiling all the warnings about deprecated symbols are gone.
ARCHIVE_COMPRESSION_*macros has been replaced. Actually I don't see anything else deprecated in
libarchivehandler.cpp, this should be all.
Revision 2 (+36 -36)
Hi again. Sorry for the lots of back and forth in what should've been a simple patch.
Since we're targeting
frameworks, we can be less conservative here and simplify a few things in one patch:
We can target libarchive3, which always has those symbols we're looking for in our
FindLibArchive. Which means we can also drop the
#ifdefchecks in the plugin.
Consequently, we can also remove our
FindLibArchive.cmake-- at the time (many years ago), it was added because CMake did not ship one, but that has not been the case since CMake 2.8.3.
LibArchive_VERSION, so we can change our
find_package()call to something like
find_package(LibArchive 3.0.0 REQUIRED)to make sure we're using a recent enough version.