Use deleteLater() to delete the selection toggle in KItemListWidget::slotHoverAnimationFinished()

Review Request #121087 - Created Nov. 9, 2014 and submitted

Information
Frank Reininghaus
kde-baseapps
Applications/14.12
334785
Reviewers
dolphin

This patch should make a crash with a backtrace as provided in the bug report impossible. I'm not sure if this would really prevent the crash - it looks like the actual cause of the problem could be in QGraphicsView or anywhere else. But I'm pretty sure that this change doesn't make anything worse.

Hovering and un-hovering icons and selection toggles works as before.

Emmanuel Pescosta
Frank Reininghaus
Review request changed

Status: Closed (submitted)

Christoph Feck

doesn't make anything worse.

There is one subtle difference between delete and deleteLater, though, which indeed might make things worse: only delete is save to be called on a null ptr.

  1. You're right, of course - thanks Christoph! I've added a safety check in http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=c65cc9207ac8ea9796f993458443a07bbcb87257

Loading...