Fix logout: Remove uneeded code to stop alt+f4 killing the window

Review Request #121004 - Created Nov. 5, 2014 and submitted

David Edmundson

Remove uneeded code to stop alt+f4 killing the window

This fixes ksmserver not being able to logout or shutdown correctly as
it was unable to kill Plasma.

Tests showed that pressing alt+f4 no longer kills the window anyway
(possibly a change in kwin or Qt?)

Previously I could not log out with:
qdbus org.kde.ksmserver /KSMServer org.kde.KSMServerInterface.logout 0 0 0

with this patch I can.

Pressed alt+f4 when desktop + panels were the only window. Nothing seemed to happen.

Bhushan Shah
David Edmundson
Aleix Pol Gonzalez
David Edmundson
Review request changed

Status: Closed (submitted)

David Edmundson

[18:19] <bshah> d__ed: IIRC Alt+F4 code was added due to bug I reported.. but it seems this is not case now... tried your patch and Alt+F4 is not killing plasmashell
[18:19] <bshah> so "Ship it!" too
[18:19] <d__ed> bshah: you're still on Qt5.3?

Martin Flöser

for the record: there was no change in KWin. I just had a look at the Alt+F4 handling (for those interested: kwin/useractions.cpp, Workspace::slotWindowClose) and desktop windows are ignored:
(active_client && !(active_client->isDesktop() || active_client->isDock()))