Remove KXMLGUIClient warning in Ark

Review Request #120783 - Created Oct. 24, 2014 and submitted

Information
Elvis Angelaccio
ark
master
5bb8e7a...
Reviewers
kdeutils
rkcosta

When Ark is run from a terminal, the following warning is displayed on exit:
ark(6384)/kdeui (kdelibs) KXMLGUIClient::~KXMLGUIClient: 0x101cf80 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.

The warning is fixed by just removing the client from the KXMLGUIFactory, in the Part destructor.
A similar fix has been done in other apps, e.g. see Kate.

This was one of the two unrelated patches that were in this other review.
The other one has been already committed to the frameworks branch, so I guess we can ignore it for master.

Compile and run Ark from Konsole. The warning is gone.

Raphael Kubo da Costa
Elvis Angelaccio
Review request changed

Status: Closed (submitted)

Boris Egorov

This patch can crash Ark on nested archives. If you open debian archive and nested archive inside it and then close both Ark windows, it crashes.

  1. Already fixed: https://bugs.kde.org/show_bug.cgi?id=341187 http://quickgit.kde.org/?p=ark.git&a=commit&h=9c30f30b38c36a31e6fcb3aa047a0247ac5a22fb

  2. Ah, good to know.

    Debian package takes changes from this patch, but not from bug 341187. Will report against Debian package then.

Loading...