fix crash when no themes are found

Review Request #120738 - Created Oct. 23, 2014 and submitted

Information
Rahul Chowdhury
khangman
frameworks
cb384f4...
Reviewers
kdeedu
apol, whiting

If the theme files are not found, the app crashes. To fix that, the show() method has been changed. It checks if the theme files exist. If none is found, a QMessageBox is displayed and the app closes. Else the theme is loaded by calling the appropriate slot.


  

Issues

  • 3
  • 0
  • 0
  • 3
Description From Last Updated
This will leak. Use the static methods, like QMessageBox::information. Or assert, it doesn't seem to be very logical not to ... Aleix Pol Gonzalez Aleix Pol Gonzalez
You didn't fix the coding style issue I mentioned. Please read all the message. Aleix Pol Gonzalez Aleix Pol Gonzalez
This is wrong. it sets the mode to what the mode is set to. The point of slotChangeTheme is to ... Jeremy Whiting Jeremy Whiting
Aleix Pol Gonzalez
Rahul Chowdhury
Aleix Pol Gonzalez
Rahul Chowdhury
Jeremy Whiting
Rahul Chowdhury
Jeremy Whiting
Rahul Chowdhury
Review request changed

Status: Closed (submitted)

Loading...