Port Konqueror from KUrl to QUrl

Review Request #120650 - Created Oct. 18, 2014 and submitted

Information
Lukáš Tinkl
kde-baseapps
frameworks
Reviewers
dfaure, emmanuelp

Port konqueror (and partially dolphin, tbd in another batch) from KUrl to QUrl

Browsing local and remote files, web, inspecting archives and embedding parts works. Also fixed the non-functional location bar.

Files


Issues

  • 5
  • 15
  • 0
  • 20
Description From Last Updated
Why this change? It kills the possibility to reuse an existing process. OK, konqueror/client needs to be ported and re-enabled, ... David Faure David Faure
surely this wouldn't compile, if this code was compiled ;) David Faure David Faure
strange indentation change here David Faure David Faure
<tab> character? (same above) David Faure David Faure
can be simplified to destUrl = destUrl.adjusted(QUrl::RemoveFilename) David Faure David Faure
Lukáš Tinkl
David Faure
Lukáš Tinkl
Emmanuel Pescosta
Emmanuel Pescosta
David Faure
Lukáš Tinkl
Review request changed

Status: Closed (submitted)

Frank Reininghaus

Lukáš, when modifying unit tests, please run them and verify that you do not introduce any new failures. Please note:

  • The correct replacement for KUrl(fileName) is QUrl::fromLocalPath(fileName)
  • urlA.adjusted(QUrl::RemoveFilename) is a no-op if you don't use the return value. The function is const.

Fix at https://git.reviewboard.kde.org/r/120941/

  1. It's actually QUrl::fromLocalFile(fileName), not "Path".

Loading...