KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

Review Request #120198 - Created Sept. 14, 2014 and submitted

Information
Alex Richardson
kservice
master
120199
Reviewers
kdeframeworks

A series of 4 commits:


KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

This means that KPluginInfo can now simply reuse the QJsonObject
returned by QPluginLoader.metaData() (by storing it in a
KPluginMetaData object instead of having to convert the JSON to a
QVariantMap first.

Additionally this allows very efficient conversion between KPluginInfo
and KPluginMetaData.


Add compatibility key names to KPluginInfo::property()


KPluginInfo: Fix loading JSON metadata that only has compatibility keys

This can be removed in KF6, but for now allows loading all both old
style as well as new style metadata


kplugininfotest: also test objects constructed from JSON

This tests both new style JSON as well as JSON using the old key names

All unit tests still work

Issues

  • 1
  • 9
  • 0
  • 10
Description From Last Updated
Missing "static" before inline, if these methods are only used in this .cpp file. David Faure David Faure
David Faure
Sebastian Kügler
Milian Wolff
Milian Wolff
Alex Richardson
David Faure
Alex Richardson
Review request changed

Status: Closed (submitted)

Loading...