Look for kdesu in the correct location
Review Request #120185 - Created Sept. 13, 2014 and submitted
|Maarten De Meyer|
kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup.
Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5?
Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is "Could not launch 'root'" which is somewhat correct but not as easy to figure out as "Could not launch 'kdesu'"
Also added an unrelated QFile::decodeName() call.
Created .desktop file with X-KDE-SubstituteUID=true
Now I can launch it as root and when I remove kdesu I got a normal error message.
Unit test no longer skips because kdesu is not found.
Look for kdesu in libexec/kf5
If you want it to be renamed or installed some other place please comment here: https://git.reviewboard.kde.org/r/120040
I don't have a strong opion on this and will just adapt to whatever Marco decides.
Revision 2 (+13 -4)
any updates on that?
here the patch works correctly after i make kdesu to be installed under CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR
I would push this asap, since kdesu in Plasma 5 is still broken.
if CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 is ok (that seems where it's the safest from a coinstallability pov), i'll move where kdesu is installed as well