Install the headers and a working KF5KExiv2Config.cmake

Review Request #119921 - Created Aug. 24, 2014 and submitted

Information
Fabio D'Urso
libkexiv2
framework
Reviewers
mlaurent

Hi,
I see that you've done some work about porting libkexiv2 to KF5.
I've tried to install the "framework" branch (without the s, as the "frameworks" branch seems to be just a copy of master), however, I had to add these lines to obtain a working installation.

The header files were not being installed, and the KF5KExiv2Config.cmake contained a broken include. The attached patch fixes these issues for me, can I push it?

Works for me, I can compile and link the library. I use it to read the EXIF orientation and it seems to work correctly.

Installed include directory tree with the patch (file/dir marked with * are those added by this patch - basically all of them except for libkexiv2_version.h):
include/ \-- KF5 |-- KEXIV2 * |   |-- kexiv2 * |   |   |-- altlangstredit.h * |   |   |-- countryselector.h * |   |   |-- kexiv2data.h * |   |   |-- kexiv2.h * |   |   |-- kexiv2previews.h * |   |   |-- msgtextedit.h * |   |   |-- rotationmatrix.h * |   |   \-- subjectwidget.h * |   |-- KExiv2 * |   |   |-- AltLangStrEdit * -> #include "kexiv2/altlangstredit.h" |   |   |-- CountrySelector * -> #include "kexiv2/countryselector.h" |   |   |-- KExiv2 * -> #include "kexiv2/kexiv2.h" |   |   |-- KExiv2Data * -> #include "kexiv2/kexiv2data.h" |   |   |-- KExiv2Previews * -> #include "kexiv2/kexiv2previews.h" |   |   |-- MsgTextEdit * -> #include "kexiv2/msgtextedit.h" |   |   |-- RotationMatrix * -> #include "kexiv2/rotationmatrix.h" |   |   \-- SubjectWidget * -> #include "kexiv2/subjectwidget.h" |   \-- kexiv2_export.h * \-- libkexiv2_version.h

Laurent Montel
Fabio D'Urso
Review request changed

Status: Closed (submitted)

Loading...