Avoid linking to unused libraries

Review Request #119908 - Created Aug. 22, 2014 and submitted

Information
Bernd Steinhauser
konsole
frameworks
Reviewers
konsole

konsole uses the variable ${X11_LIBRARIES} for linking, which will result in linking against libX11, libSM, libICE and libXext.
In the source code, I could only find usages of libX11, so I propose to use ${X11_X11_LIB} instead of ${X11_LIBRARIES}. However, I'm not familiar with konsole's code and I'm not a c++ coder, so it could be that I overlooked some usage of the other libraries.

konsole with current HEAD of the frameworks branch was built with the patch applied. It compiled, linked and ran without any issues, that could be related to the applied diff.

Bernd Steinhauser
Review request changed

Status: Closed (submitted)

Loading...