[Dolphin] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

Review Request #119892 - Created Aug. 21, 2014 and updated

Information
Arjun AK
kde-baseapps
338414
Reviewers
kde-baseapps, kdeutils
dfaure

This patch implements the "Add to archive" option, which is shown when a user drags and drops files onto an existing archive.

See also:
https://git.reviewboard.kde.org/r/119890
https://bugs.kde.org/show_bug.cgi?id=338414


  

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
What should be done with this? Is this feature necessary? Arjun AK Arjun AK
Yes, dropping a file onto an executable sounds like a good feature to have. Why disable it? It seems unrelated ... David Faure David Faure
Arjun AK
Emmanuel Pescosta
Frank Reininghaus
Arjun AK
Review request changed

People:

+dfaure
David Faure

   
lib/konq/konq_operations.cpp (Diff revision 1)
 
 

Yes, dropping a file onto an executable sounds like a good feature to have. Why disable it? It seems unrelated to the feature in this patch; just select the correct code path depending on whether you're dropping onto an executable or an archive....

Basically, refactor the code in the next hunk, which finds out if ark supports that mimetype, into a separate function that returns true if supported by ark, false if not. Doing the KService lookup twice is not a problem.

Loading...