Fix build of KDELibs4Support, qMessageFormatString

Review Request #119604 - Created Aug. 4, 2014 and submitted

Information
Aleix Pol Gonzalez
kdelibs4support
Reviewers
plasma

We were using some private API that now it's public, but it got renamed in the process.

With this patch, we only fetch the old function name if we're on 5.3, and we create dummy function with the new name, otherwise.

I get to build kdelibs4support.

Kevin Funk
Aleix Pol Gonzalez
Review request changed

Status: Closed (submitted)

Hrvoje Senjan

i don't know is there maybe a 'better' solution; i know Qt changes internal API, but we still have a BC breakage:
undefined symbol: _Z20qMessageFormatString9QtMsgTypeRK18QMessageLogContextRK7QString

  1. Well, you shouldn't be getting this if you have my patch in.

  2. the lib is borked with: kdelibs4support HEAD built against Qt 5.3 and used with Qt 5.4 at runtime

  3. Well there isn't much we can do about that. We shouldn't have used a private symbol. spank

Loading...