QueryParser: Use $ instead of % in the pattern strings

Review Request #119519 - Created July 28, 2014 and submitted

Information
Vishesh Handa
baloo
KDE/4.14
Reviewers
baloo
dsteckelmacher
We use placeholders such as '%1' in order to indicate the kind of
pattern we want to match. Eg - '%1 years'. The translators are then free
to move the '%' around if in the language the number comes after the
years.

However, using %1 in the strings causes KLocalizedString to replace the
%1 with KI18N_ARGUMENT_MISSING when not compiled in debug mode. This is
incorrect as we want the %1 to be there in the final string. With this
patch we now use $ instead of %.

unit tests pass

Denis Steckelmacher
Vishesh Handa
Review request changed

Status: Closed (submitted)

Loading...