Limit linking kipi-plugins to OpenCV libraries to only needed components

Review Request #119413 - Created July 22, 2014 and submitted

Information
Vadim Zhukov
kipi-plugins
Reviewers
digikam
  1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
  2. Limit KIPI plugins linking to only OpenCV components it really uses.

This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.

Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

OpenBSD/i386-CURRENT

Gilles Caulier
Vadim Zhukov
Gilles Caulier
Vadim Zhukov
Vadim Zhukov
Review request changed

Status: Closed (submitted)

Gilles Caulier

Vadim,

I must use the same components defined into libkface for RemoveRedEyes, else link do not work properly...

  1. Does it happen on OS X only? Are there any "find_package(OpenCV)" (without "COMPONENTS") in your build somewhere?

Gilles Caulier

Same problem under Windows and Linux

Loading...