Dont show context menu when dragging and dropping onto read only folders in the places menu
Review Request #119399 - Created July 22, 2014 and discarded
|path() --> toLocalFile()||David Faure|
Thanks for the patch! I agree that not showing the "Move/Copy/Link" menu when dropping items on a read-only entry in the Places Panel makes sense (because selecting any action in the menu triggers an error message in a message box, which must be clicked away).
However, I think that we should not use the KMessageWidget for this kind of non-critical error messages. In the past years, we got quite a bit of feedback from users who considered the message widget annoying (e.g., when showing the "Folder cannot be dropped on itself" message). It's different for critical messages (like "Cannot enter directory xyz") though.
Thanks for the updated patch and sorry for the late reply. I was away for most of last week and still haven't finished reading all incoming mails yet.
I'm a bit unsure if showing the error message in the status bar is the best solution. A better solution might be to simply show a "Drop forbidden" mouse cursor while hovering read-only items, such that the drop would not be possible at all.
However, finding out if a device is read-only or not will require mounting the device first, but we do not want to mount a device simply by hovering it, I think - this would be unwanted in many situations, and it might freeze the GUI if mounting takes some time.
Maybe we should show the "drop forbidden" cursor if we can find out about the read-only state quickly, and only show the error message if that is not the case? Maybe I have to think about some more, but any ideas from you and others are welcome as well, of course.
You might also want to add David Faure as a reviewer beccause he is responsible for lib/konq.