Actually pass IBUS_DEFINITIONS when compiling ibus-panel

Review Request #119025 - Created June 30, 2014 and discarded

Information
Vadim Zhukov
kimtoy
Reviewers
kde-workspace, plasma
nihui

The ibus-panel can't build on OpenBSD because some required definitions obtained from pkgconfig file are not used. This happens due to the following reasons:

1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt
2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at compile time

This patch resolves both issues and makes ibus-panel compile on OpenBSD.

(I found no suitable review group and therefore used "plasma" instead, as it was in "plasma-addons" previously; please, feel free to correct me if I'm wrong and sorry for any possible inconvenience)

((as there was no feedback for more than a week, I've added "kde-workspace" group to list of reviewers, too))

OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy package, of course, but the code is same)

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Vadim Zhukov
Vadim Zhukov
Vadim Zhukov
Hui Ni
Raphael Kubo da Costa
Vadim Zhukov
David Edmundson
Vadim Zhukov
Review request changed

Status: Discarded

Loading...