Remove current item highlighting in the Places Panel

Review Request #119019 - Created June 29, 2014 and submitted

Information
Frank Reininghaus
kde-baseapps
master
Reviewers
dolphin
In the Places Panel, there is always exactly one selected item, which is equal to the current item. Since the selected item is highlighted by drawing its background in a different color, it is not really necessary to highlight additionally that it is the current item.

This can be achieved by removing the calls to KItemListWidget::setCurrent(true) from KItemListView. The "current" information in the widget is only used for deciding if the "current item hightlighting", like an underline in Oxygen, should be drawn.

The motivation for this change is that I have seem some complaints about the "current item" highlighting, which can be even more distracting with non-Oxygen styles, see, e.g.,

http://forum.kde.org/viewtopic.php?f=224&t=121469

http://wheeldesign.blogspot.de/2014/06/monday-report-bi-weekly-edition.html?showComment=1402687299283#c2139876221548977296
See screenshots, which show the current master branch, the change caused by this patch, and finally, the effect of this patch and https://git.reviewboard.kde.org/r/119018/ combined.

Files


Mark Gaiser
Emmanuel Pescosta
Commit Hook
This review has been submitted with commit d329e0ed72f2291b923cb81a12f2b165e457aab3 by Frank Reininghaus to branch master.
Frank Reininghaus
Review request changed

Status: Closed (submitted)

Loading...